Versions Compared

Old Version 7

changes.mady.by.user James Cooley

Saved on

compared with

New Version Current

changes.mady.by.user James Cooley

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • The comment / reject reason / test report is communicated back to the contributor as a comment in the changes and also in the JIRA ticket.
  • Set the topic to `contributor-review` if it is not set by the original contributor.
  • Set the Review-Stat State label to -1 or -2.

TIPS

  • Review State can be reset by a new patchset which has new code, in this case you may need to reset RS +1 , it is not reset on a trivial rebase or commit message change
  • If a downstream change is updated post downstream the scm set review state jenkins job will fail, you need to manually set RS+1 and remove and + 5, + 6 etc RS votes