Page History

Module : rtRemote

src/rtRemoteValueWriter.cpp

Module : rdkservices

git/RDKShell/RDKShell.cpp

| /home/pjames993/64bit_rpi4_apr18/build-raspberrypi4-64-rdk-hybrid/tmp/work/aarch64-rdk-linux/rdkservices/3.0+gitAUTOINC+2f0616e469-r1/git/RDKShell/RDKShell.cpp:1099:62: error: cannot bind non-const lvalue reference of type 'uint32_t&' {aka 'unsigned int&'} to an rvalue of type 'uint32_t' {aka 'unsigned int'}

|  1099 |                       CompositorController::screenShot(data, size);

|       |                                                              ^~~~

@@ -1067,7 +1094,7 @@ namespace WPEFramework {

                   if (needsScreenshot)

                   {

                       uint8_t* data = nullptr;

-                      size_t size;

+                      uint32_t size;

                       string screenshotBase64;

                       CompositorController::screenShot(data, size);

                       size_t encodedImageSize = b64_get_encoded_buffer_size(size);

../../git/src/rdkx_logger_level.hash:61:1: error: conflicting types for 'rdkx_logger_level_str_to_num'

| In file included from ../../git/src/rdkx_logger_level.hash:6:

| ../../git/src/rdkx_logger_private.h:25:30: note: previous declaration of 'rdkx_logger_level_str_to_num' was here

|    25 | struct rdkx_logger_level_s * rdkx_logger_level_str_to_num(const char *str, unsigned int len);

|       |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

diff --git a/src/rdkx_logger_private.h b/src/rdkx_logger_private.h

index 49224e5..a475514 100644

--- a/src/rdkx_logger_private.h

+++ b/src/rdkx_logger_private.h

@@ -18,8 +18,10 @@

 # limitations under the License.

 ############################################

 */

+

+#include <stddef.h>

 typedef struct rdkx_logger_module_s { char *name; unsigned char id; } rdkx_logger_module_t;

 typedef struct rdkx_logger_level_s  { char *name; unsigned char level; } rdkx_logger_level_t;

-struct rdkx_logger_module_s *rdkx_logger_module_str_to_index(const char *str, unsigned int len);

-struct rdkx_logger_level_s * rdkx_logger_level_str_to_num(const char *str, unsigned int len);

+struct rdkx_logger_module_s *rdkx_logger_module_str_to_index(const char *str, size_t len);

+struct rdkx_logger_level_s * rdkx_logger_level_str_to_num(const char *str, size_t len);

Module : xr-speech-vrex

src/xrsv_ws/xrsv_ws_private.h

xrsv_ws_nextgen/xrsv_ws_nextgen_private.h

| ../../git/src/xrsv_ws/xrsv_ws_request.hash:61:1: error: conflicting types for 'xrsv_ws_request_handler_get'

| In file included from ../../git/src/xrsv_ws/xrsv_ws_request.hash:6:

| ../../git/src/xrsv_ws/xrsv_ws_private.h:83:36: note: previous declaration of 'xrsv_ws_request_handler_get' was here

|    83 | struct xrsv_ws_request_handler_s * xrsv_ws_request_handler_get(const char *str, unsigned int len);

|       |                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~

| Makefile:542: recipe for target 'xrsv_ws/xrsv_ws_request.lo' failed

| make[3]: *** [xrsv_ws/xrsv_ws_request.lo] Error 1

*********************************************

| ../../git/src/xrsv_ws/xrsv_ws_action_phone.hash:61:1: error: conflicting types for 'xrsv_ws_action_phone_handler_get'

| In file included from ../../git/src/xrsv_ws/xrsv_ws_action_phone.hash:6:

| ../../git/src/xrsv_ws/xrsv_ws_private.h:85:36: note: previous declaration of 'xrsv_ws_action_phone_handler_get' was here

|    85 | struct xrsv_ws_action_handler_s *  xrsv_ws_action_phone_handler_get(const char *str, unsigned int len);

|       |                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

| Makefile:542: recipe for target 'xrsv_ws/xrsv_ws_action_phone.lo' failed

| make[3]: *** [xrsv_ws/xrsv_ws_action_phone.lo] Error 1

| ../../git/src/xrsv_ws_nextgen/xrsv_ws_nextgen_tv_control.hash:61:1: error: conflicting types for 'xrsv_ws_nextgen_tv_control_handler_get'

| In file included from ../../git/src/xrsv_ws_nextgen/xrsv_ws_nextgen_tv_control.hash:6:

| ../../git/src/xrsv_ws_nextgen/xrsv_ws_nextgen_private.h:79:47: note: previous declaration of 'xrsv_ws_nextgen_tv_control_handler_get' was here

|    79 | struct xrsv_ws_nextgen_tv_control_handler_s * xrsv_ws_nextgen_tv_control_handler_get(const char *str, unsigned int len);

|       |                                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

| ../../git/src/xrsv_ws_nextgen/xrsv_ws_nextgen_msgtype.hash:61:1: error: conflicting types for 'xrsv_ws_nextgen_msgtype_handler_get'

| In file included from ../../git/src/xrsv_ws_nextgen/xrsv_ws_nextgen_msgtype.hash:6:

| ../../git/src/xrsv_ws_nextgen/xrsv_ws_nextgen_private.h:78:44: note: previous declaration of 'xrsv_ws_nextgen_msgtype_handler_get' was here

|    78 | struct xrsv_ws_nextgen_msgtype_handler_s * xrsv_ws_nextgen_msgtype_handler_get(const char *str, unsigned int len);

|       |                                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

| ../../git/src/xrsv_ws/xrsv_ws_action.hash:61:1: error: conflicting types for 'xrsv_ws_action_handler_get'

| In file included from ../../git/src/xrsv_ws/xrsv_ws_action.hash:6:

| ../../git/src/xrsv_ws/xrsv_ws_private.h:84:36: note: previous declaration of 'xrsv_ws_action_handler_get' was here

|    84 | struct xrsv_ws_action_handler_s *  xrsv_ws_action_handler_get(const char *str, unsigned int len);

|       |                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~

| Makefile:542: recipe for target 'xrsv_ws/xrsv_ws_action.lo' failed

| make[3]: *** [xrsv_ws/xrsv_ws_action.lo] Error 1

diff --git a/src/xrsv_ws/xrsv_ws_private.h b/src/xrsv_ws/xrsv_ws_private.h

index eecd6fb..6765591 100644

--- a/src/xrsv_ws/xrsv_ws_private.h

+++ b/src/xrsv_ws/xrsv_ws_private.h

@@ -78,8 +78,8 @@ typedef bool (*xrsv_ws_handler_bool_t)(xrsv_ws_obj_t *obj, json_t *obj_json);

 typedef struct xrsv_ws_request_handler_s { char *name; xrsv_ws_handler_bool_t func; } xrsv_ws_request_handler_t;

 typedef struct xrsv_ws_action_handler_s  { char *name; xrsv_ws_handler_void_t func; } xrsv_ws_action_handler_t;

-struct xrsv_ws_request_handler_s * xrsv_ws_request_handler_get(const char *str, unsigned int len);

-struct xrsv_ws_action_handler_s *  xrsv_ws_action_handler_get(const char *str, unsigned int len);

-struct xrsv_ws_action_handler_s *  xrsv_ws_action_phone_handler_get(const char *str, unsigned int len);

+struct xrsv_ws_request_handler_s * xrsv_ws_request_handler_get(const char *str, size_t len);

+struct xrsv_ws_action_handler_s *  xrsv_ws_action_handler_get(const char *str, size_t len);

+struct xrsv_ws_action_handler_s *  xrsv_ws_action_phone_handler_get(const char *str, size_t len);

 #endif

diff --git a/src/xrsv_ws_nextgen/xrsv_ws_nextgen_private.h b/src/xrsv_ws_nextgen/xrsv_ws_nextgen_private.h

index 8daee81..e6bb2a6 100644

--- a/src/xrsv_ws_nextgen/xrsv_ws_nextgen_private.h

+++ b/src/xrsv_ws_nextgen/xrsv_ws_nextgen_private.h

@@ -73,7 +73,7 @@ typedef void (*xrsv_ws_nextgen_handler_void_t)(xrsv_ws_nextgen_obj_t *obj, json_

 typedef struct xrsv_ws_nextgen_msgtype_handler_s { char *name; xrsv_ws_nextgen_handler_bool_t func; } xrsv_ws_nextgen_msgtype_handler_t;

 typedef struct xrsv_ws_nextgen_tv_control_handler_s { char *name; xrsv_ws_nextgen_handler_void_t func; } xrsv_ws_nextgen_tv_control_handler_t;

-struct xrsv_ws_nextgen_msgtype_handler_s * xrsv_ws_nextgen_msgtype_handler_get(const char *str, unsigned int len);

-struct xrsv_ws_nextgen_tv_control_handler_s * xrsv_ws_nextgen_tv_control_handler_get(const char *str, unsigned int len);

+struct xrsv_ws_nextgen_msgtype_handler_s * xrsv_ws_nextgen_msgtype_handler_get(const char *str, size_t len);

+struct xrsv_ws_nextgen_tv_control_handler_s * xrsv_ws_nextgen_tv_control_handler_get(const char *str, size_t len);

Module : mediaframework

qamsource/simgr/oob/include/rmf_sicache.h

| ../../../../git/qamsource/simgr/oob/./src/rmf_oobsicache.cpp:5856:70: error: cast from 'rmf_SiTableEntry*' to 'rmf_SiServiceHandle' {aka 'unsigned int'} loses precision [-fpermissive]

|  5856 |                         ts->services->push_back((rmf_SiServiceHandle)new_si_entry);

|       |                                                                      ^~~~~~~~~~~~

| ../../../../git/qamsource/simgr/oob/./src/rmf_oobsicache.cpp:5890:73: error: cast from 'rmf_SiTransportStreamEntry*' to 'rmf_SiTransportStreamHandle' {aka 'unsigned int'} loses precision [-fpermissive]

|  5890 |                 new_si_entry->ts_handle = (rmf_SiTransportStreamHandle) ts;

|       |                                                                         ^~

| ../../../../git/qamsource/simgr/oob/./src/rmf_oobsicache.cpp:5891:62: error: cast from 'rmf_SiProgramInfo*' to 'rmf_SiProgramHandle' {aka 'unsigned int'} loses precision [-fpermissive]

|  5891 |                 new_si_entry->program = (rmf_SiProgramHandle)pgm;

|       |                                                              ^~~

Module : wpe-webkit

git/Source/WebCore/platform/ttsclient/PlatformSpeechSynthesizerTTSClient.cpp

| /home/pjames993/64bit_rpi4_apr18/build-raspberrypi4-64-rdk-hybrid/tmp/work/aarch64-rdk-linux/wpe-webkit/2.22.4+gitAUTOINC+ed39c92e59-r0/git/Source/WebCore/platform/ttsclient/PlatformSpeechSynthesizerTTSClient.cpp:185:40: error: cast from 'WebCore::PlatformSpeechSynthesisUtterance*' to 'uint32_t' {aka 'unsigned int'} loses precision [-fpermissive]

| /home/pjames993/64bit_rpi4_apr18/build-raspberrypi4-64-rdk-hybrid/tmp/work/aarch64-rdk-linux/wpe-webkit/2.22.4+gitAUTOINC+ed39c92e59-r0/git/Source/WebCore/platform/ttsclient/PlatformSpeechSynthesizerTTSClient.cpp:234:78: error: cast from 'WebCore::PlatformSpeechSynthesisUtterance*' to 'uint32_t' {aka 'unsigned int'} loses precision [-fpermissive]
|   234 |         m_ttsClient->resume(m_ttsSessionId, (uint32_t)m_currentUtterance.get());
|       |                                                                              ^

| /home/pjames993/64bit_rpi4_apr18/build-raspberrypi4-64-rdk-hybrid/tmp/work/aarch64-rdk-linux/wpe-webkit/2.22.4+gitAUTOINC+ed39c92e59-r0/git/Source/WebCore/platform/ttsclient/PlatformSpeechSynthesizerTTSClient.cpp:273:59: error: cast from 'WebCore::PlatformSpeechSynthesisUtterance*' to 'uint32_t' {aka 'unsigned int'} loses precision [-fpermissive]
|   273 |         speakingFinished((uint32_t)m_currentUtterance.get(), SpeechErrorInterrupted);
|       |                                                           ^

This change will not impact any of the basic functionalities.

STATUS : MERGED

Module : qtbase

../../../../include/QtGui/../../../qtbase-opensource-src-5.1.1/src/gui/opengl/qopengl.h:97:17: error: conflicting declaration 'typedef GLfloat GLdouble'

   97 | typedef GLfloat GLdouble;

      |                 ^~~~~~~~

In file included from /home/kpandu549/keerthana/oct27-v/build-raspberrypi4-64-rdk-hybrid/tmp/work/aarch64-rdk-linux/qtbase/5.1.1-r0/qtbase-opensource-src-5.1.1/src/plugins/platforms/kms/qkmsscreen.h:59,

                 from /home/kpandu549/keerthana/oct27-v/build-raspberrypi4-64-rdk-hybrid/tmp/work/aarch64-rdk-linux/qtbase/5.1.1-r0/qtbase-opensource-src-5.1.1/src/plugins/platforms/kms/qkmsintegration.cpp:44:

/home/kpandu549/keerthana/oct27-v/build-raspberrypi4-64-rdk-hybrid/tmp/work/aarch64-rdk-linux/qtbase/5.1.1-r0/recipe-sysroot/usr/include/GLES2/gl2ext.h:3092:16: note: previous declaration as 'typedef double GLdouble'

 3092 | typedef double GLdouble;

https://code.rdkcentral.com/r/plugins/gitiles/components/generic/rdk-oe/meta-cmf-qt5/+/refs/heads/rdk-next/recipes-qt/qt5/qtbase_5.1.1.bbappend

SRC_URI_append_arm = " \
    file://0003-GLdouble-conflict-declaration-fix.patch \
"

https://code.rdkcentral.com/r/plugins/gitiles/components/generic/rdk-oe/meta-cmf-qt5/+/refs/heads/rdk-next/recipes-qt/qt5/qtbase-5.1.1/0003-GLdouble-conflict-declaration-fix.patch

diff --git a/src/gui/opengl/qopengl.h b/src/gui/opengl/qopengl.h

index 6e8be668..524e1860 100644

--- a/src/gui/opengl/qopengl.h

+++ b/src/gui/opengl/qopengl.h

@@ -94,7 +94,7 @@ typedef char GLchar;

 #   define GL_DOUBLE GL_FLOAT

 #  endif

 #  ifndef GLdouble

-typedef GLfloat GLdouble;

+typedef double GLdouble;

 #  endif

 # endif // Q_OS_MAC

Issue is resolved and uploaded for review.

Current Status : Code Merged

| /home/pjames993/64bit_rpi4_apr18/build-raspberrypi4-64-rdk-hybrid/tmp/work/aarch64-rdk-linux/sessionmgr/git-r0/git/src/SessionMgr.cpp: In function 'session_err_t sessionmgr_GetSessionProperty(session_t*, const char*, SimpleJsonEnc&)':

| /home/pjames993/64bit_rpi4_apr18/build-raspberrypi4-64-rdk-hybrid/tmp/work/aarch64-rdk-linux/sessionmgr/git-r0/git/src/SessionMgr.cpp:14850:88: error: call of overloaded 'addNum(const char*&, const char [4], int64_t)' is ambiguous

| 14850 |             response.addNum(property, "%" PRId64, session->source->getTimeshiftBuffer());

|       |                                                                                        ^

Initial Solution:

response.addNum(property, "%" PRId64, (long long)session->source->getTimeshiftBuffer())

In file included from ../../git/anycas/demoCas/demoCas.cpp:22:

../../git/anycas/demoCas/demoCas.h: In member function 'virtual void DemoCasHelper::processData(std::shared_ptr<anycas::CASHelperContext>, bool, const std::vector<unsigned char>&)':
../../git/anycas/demoCas/demoCas.h:295:43: error: cast from 'char*' to 'uint32_t' {aka 'unsigned int'} loses precision [-fpermissive]
  295 |                 uint32_t addr = (uint32_t)pvtData;
      |                                           ^~~~~~~

Intial Solution :

    uint32_t addr = (uintptr_t)pvtData;

Resolution is identified and added for code review.

STATUS : SPRINT_OPENMERGED

../git/rdkmediaplayer.cpp: In member function 'rtError RDKMediaPlayer::open(rtString, rtString)':
../git/rdkmediaplayer.cpp:764:42: error: cast from 'RDKMediaPlayerImpl*' to 'uint32_t' {aka 'unsigned int'} loses precision [-fpermissive]
  764 |         resp = (std::to_string((uint32_t)m_pImpl)).c_str();
      |                                          ^~~~~~~
../git/rdkmediaplayer.cpp:785:51: error: cast from 'RDKMediaPlayerImpl*' to 'uint32_t' {aka 'unsigned int'} loses precision [-fpermissive]
  785 |                 resp = (std::to_string((uint32_t)*it)).c_str();
      |                                                   ^~

Solution :

--- a/rdkmediaplayer.cpp

+++ b/rdkmediaplayer.cpp

@@ -761,7 +761,7 @@ rtError RDKMediaPlayer::open(rtString openData, rtString resp)

         {

             LOG_INFO("CAS Managment session is already avialable");

         }

-        resp = (std::to_string((uint32_t)m_pImpl)).c_str();

+        resp = (std::to_string((uintptr_t)m_pImpl)).c_str();

         LOG_INFO("resp = %x", resp.cString());

     }

     // For Live Playback Session

@@ -782,7 +782,7 @@ rtError RDKMediaPlayer::open(rtString openData, rtString resp)

             if( !((*it)->isManagementSession()) && (*it)->doCanPlayURL(m_currentURL) )

             {

                 LOG_INFO("Reusing cached player");

-                resp = (std::to_string((uint32_t)*it)).c_str();

+                resp = (std::to_string((uintptr_t)*it)).c_str();

                 LOG_INFO("resp = %x", resp.cString());

             }