...
- Ensure you or your company have signed the appropriate CLA as discussed in the Before You Contribute section above.
- Rebase your changes down into a single git commit.
- Run
git push command
to upload the review to code.rdkcentral.com. - Someone from the maintainers team reviews the code, adding comments on any things that need to change before the code can be submitted.
- If you need to make changes, make them locally, test them, then
git commit --amend
to add them to the existing commit. Then return to step 2. - If you do not need to make any more changes, a maintainer integrates the change into our private repository, and it is pushed out to the public repository after some time.
Contributor License Agreement (CLA) - RDK Central Github
The RDK CLA facilitates the acceptance and sharing of RDK contributions within the community.
When you contribute to an RDK open source project on GitHub via a new pull request, a bot will evaluate whether you have signed the CLA. The bot will comment on the pull request, including a link to accept the agreement.
CLA assistant enables contributors to sign CLAs from within a pull request. The CLA is stored as a GitHub Gist file and linked with the repository/organisation in CLA assistant.
CLA assistant
- Comments on each opened pull request to ask the contributor to sign the CLA
- Allows contributors to sign a CLA from within a pull request
- Authenticates the signee with his or her GitHub account
- Updates the status of a pull request when the contributor agrees to the CLA
- Automatically asks users to re-sign the CLA for each new pull request in the event the associated Gist & CLA has changed
- Repository owners can review a list of users who signed the CLA for each version of it.
Note - CLA assistant is provided by SAP as a free hosted offering under: https://cla-assistant.io/