AAMP Coding Guidelines

Dashboard link for current Sprint progress : https://ccp.sys.comcast.net/Dashboard.jspa?selectPageId=72972 

• When you start work on ticket , move ticket status to Code development . Update Development Owner and Development Manager.  Ensure Sprint label is added.  For April/May Sprint its aamp_2004
• When closing ticket (duplicate / or any reason) , update triage info with explanation and root cause analysis..
• Please update ticket with development logs before sharing the review
• Code review or Ticket must include clear test procedure for QA, not generic "Tested in Xi5/Xi6"
• Whenever you raise any code review outside AAMP like AVE / XRE / Fog  , make sure you trigger verification build manually . Here is the link https://jenkins.ccp.xcal.tv/jenkins/job/Gerrit-Trigger-Custom-Verification-SingleReview-Pipeline/  . This will speed up merge process.

Check for compilation warnings - some can be dangerous.

Use proper printf format specifiers, i.e.

Steps for using Coverity tool:

1.     Procure access to Coverity portal
·       Coverity Portal url: https://coverity-wc-a1.cable.comcast.com/login/login.htm
·       Credentials : NTID and password
·       Raise RDKSVREQ ticket for access permission.
·       Sample Request: https://ccp.sys.comcast.net/browse/RDKSVREQ-21961
·       Please note that it takes 24 hrs for the activation to reflect in the Coverity portal
2.     Create gerrit link for the latest code check in
·       Complete the code changes in the dev_sprint.
·       Obtain the patch using the command
	--> git format-patch -1
·       Raise  the gerrit , along with the bb file in the required the sprint
              Similar to this -> https://gerrit.teamccp.com/#/c/433297/
3.     Generate Jenkins build with the Gerrit patch set generated as part of step 2 and USE_COVERITY flag checked
4.     Once the build is successful, get the 'snapshot ID ' from the Jenkins build console logs. Just search for the string 'snapshot ID ' in the Console Output -> full log for the Jenkins build.
5.     Login to the coverity portal and navigate to Snapshots->All in project
6.     Will get a list of snapshotid's , select the snapshot id got from build, navigate to the aamp component and check for the new defects that were observed by checking the new defects and the date
7.     Will be listed with the new set of defects that were observed, check whether there is any defects new raised from the current file changes.
8.     Once the bugs identified are fixed, use the same procedure to confirm that the Coverity scan finds the issues fixed.